-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: testnet fixes #1106
fix: testnet fixes #1106
Conversation
BX-1115 Force Connect Network Ordering based on Networks list
timmy said:
BX-1113 Testnet Mode Asset/Transaction Discovery (missing data)
grant said:
|
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝
@@ -18,9 +19,12 @@ export function selectorFilterByUserChains<T>({ | |||
selector: (data: ParsedAssetsDictByChain) => T; | |||
}): T { | |||
const { userChains } = userChainsStore.getState(); | |||
const allUserChainIds = Object.keys(userChains) | |||
.map((chainId) => chainIdMap[Number(chainId)]) | |||
.flat(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
c26a997
to
1ca71e3
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-1115
Fixes BX-1113
Figma link (if any):
What changed (plus any additional context for devs)
the was an error while saving chain orders in state
in networks settings we only have mainnet chains to reorder and enable/disable but we were updating the order in an array of all chains, testnets and mainnets, so the filtering of the chains was messed up on networks modal, assets and txs
Screen recordings / screenshots
What to test
plz check the tickets, i've tried to break it but looking ok now