Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testnet fixes #1106

Merged
merged 4 commits into from
Nov 2, 2023
Merged

fix: testnet fixes #1106

merged 4 commits into from
Nov 2, 2023

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Nov 1, 2023

Fixes BX-1115
Fixes BX-1113

Figma link (if any):

What changed (plus any additional context for devs)

the was an error while saving chain orders in state

in networks settings we only have mainnet chains to reorder and enable/disable but we were updating the order in an array of all chains, testnets and mainnets, so the filtering of the chains was messed up on networks modal, assets and txs

Screen recordings / screenshots

What to test

plz check the tickets, i've tried to break it but looking ok now

Copy link

linear bot commented Nov 1, 2023

@estebanmino estebanmino marked this pull request as ready for review November 1, 2023 18:52
Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e18b08e7b51335486570e02efa22a5b6d2b9b195.zip
screenshots

Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@@ -18,9 +19,12 @@ export function selectorFilterByUserChains<T>({
selector: (data: ParsedAssetsDictByChain) => T;
}): T {
const { userChains } = userChainsStore.getState();
const allUserChainIds = Object.keys(userChains)
.map((chainId) => chainIdMap[Number(chainId)])
.flat();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9fe5f39d19cb11f1f8050eabf65ed1defe34628f.zip
screenshots

Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9fe5f39d19cb11f1f8050eabf65ed1defe34628f.zip
screenshots

@DanielSinclair
Copy link
Collaborator

Working for me now 👌
Screenshot 2023-11-01 at 5 25 38 PM
Screenshot 2023-11-01 at 5 25 33 PM
Screenshot 2023-11-01 at 5 26 15 PM
Screenshot 2023-11-01 at 5 25 59 PM

Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9fe5f39d19cb11f1f8050eabf65ed1defe34628f.zip
screenshots

Copy link

github-actions bot commented Nov 2, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9a49a10a75c496e45a465d4df0b3b578f9cf5093.zip

@estebanmino estebanmino merged commit 1502245 into master Nov 2, 2023
16 checks passed
@estebanmino estebanmino deleted the @esteban/testnet-fixes branch November 2, 2023 14:12
Copy link

github-actions bot commented Nov 2, 2023

Here's the packed extension for this build:
rainbowbx-15022452a45ae25b92217d7775252f9bececd368.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants